.gitignore (1)

15-16: Be explicit about directory ignore and broaden .DS_Store pattern

Use a trailing slash to avoid matching files named “dist”, and ignore .DS_Store everywhere.

- dist
-.DS_Store
+ dist/
+ **/.DS_Store

docs/en/solutions/Leveraging_Knative_Eventing_for_Cloud_Event_Publishing_and_Consuming.md (8)

128-149: Nit: fix wording and pin image

Minor grammar and supply-chain hygiene.

- # Change to inhouse registry address and image
+ # Change to your in-house registry address and pin the image by digest
- image: gcr.io/knative-releases/knative.dev/eventing/cmd/event_display
+ image: gcr.io/knative-releases/knative.dev/eventing/cmd/event_display@sha256:<digest>

---

200-205: Clarify Trigger filters syntax vs. API version

Knative supports both legacy spec.filter.attributes and newer spec.filters forms depending on version. Document the target version and stick to one form throughout to avoid confusion.

---

363-369: Fix typos and phrasing

Small editorial cleanups.

-For this part we will still build uppon the EventConsumer created on the last part.
+For this part, we will build upon the EventConsumer created in the previous section.

---

559-574: Prefer env var over hard-coded default

Given you already set KNATIVE_BROKER_URL in the Deployment, avoid baking a cluster-specific default in code.

-    url: http://broker-ingress.knative-operator.svc.cluster.local/my-app-namespace/default
+    url: ${KNATIVE_BROKER_URL}

---

695-705: Clarify service address for curl

Kubernetes Service isn’t externally accessible by default. Suggest using the in-cluster DNS name or port-forwarding for testing.

-Change the address to its full qualified URL and try the API:
+From inside the cluster, use: http://springboot-event-app.my-app-namespace.svc.cluster.local/api/users
+For local testing, first run: kubectl -n my-app-namespace port-forward svc/springboot-event-app 8080:80
+Then curl: http://localhost:8080/api/users

---

711-727: Trigger filter form inconsistent with earlier examples

Earlier you used spec.filters; here you switched to spec.filter.attributes. Please standardize to one form for the targeted Knative version.

---

56-61: Editorial fixes for consistency and typos

Quick pass to improve readability and consistency (CloudEvents, Spring Boot, etc.).

- The following steps uses `Alauda DevOps Eventing v3` plugin
+ The following steps use the `Alauda DevOps Eventing v3` plugin
- Lets create a simple HTTP service that receives and output events as logs:
+ Let's create a simple HTTP service that receives events and outputs them as logs:
- ## Chapter 3. Enabling SpringBoot Applications for Cloud Events
+ ## Chapter 3. Enabling Spring Boot Applications for CloudEvents
-     com.example: DEBUG
+     com.example: DEBUG
- ### Testing the SpringBoot Application
+ ### Testing the Spring Boot Application
- And our main entrypoint
+ Main application entry point

Also, the document jumps from Chapter 3 to Chapter 5; renumber or add the missing Chapter 4.

Also applies to: 128-129, 239-239, 571-574, 695-695, 803-805

---

207-207: Add link label punctuation

Grammar nit.

-For a more detailed reference on Triggers, refer to the [Knative documentation](https://knative.dev/docs/eventing/triggers/).
+For a more detailed reference on Triggers, refer to the [Knative documentation](https://knative.dev/docs/eventing/triggers/).

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

docs/en/solutions/Leveraging_Knative_Eventing_for_Cloud_Event_Publishing_and_Consuming.md (4)

28-28: Add descriptive alt text to the image

Image is missing alt text; keep current path and add a concise description.

-![](/KB250700002/knative-eventing.png)
+![Knative Eventing architecture](/KB250700002/knative-eventing.png)

---

281-322: Null-safe data logging, charset, and remove unused import

Avoid NPE when data is absent, specify UTF-8, and drop an unused import.

 import io.cloudevents.http.HttpMessageFactory;
-import io.cloudevents.jackson.JsonFormat;
+import java.nio.charset.StandardCharsets;
@@
-            logger.info("  Data: {}", new String(event.getData().toBytes()));
+            if (event.getData() != null) {
+                logger.info("  Data: {}", new String(event.getData().toBytes(), StandardCharsets.UTF_8));
+            } else {
+                logger.info("  Data: <none>");
+            }

---

463-499: Add HTTP timeouts and ensure disconnect/stream cleanup

Prevent resource leaks and hanging connections; also guard null error stream.

-    private void publishEvent(CloudEvent event) {
-        try {
-            URL url = URI.create(brokerUrl).toURL();
-            HttpURLConnection httpUrlConnection = (HttpURLConnection) url.openConnection();
+    private void publishEvent(CloudEvent event) {
+        HttpURLConnection httpUrlConnection = null;
+        try {
+            URL url = URI.create(brokerUrl).toURL();
+            httpUrlConnection = (HttpURLConnection) url.openConnection();
             httpUrlConnection.setRequestMethod("POST");
             httpUrlConnection.setDoOutput(true);
             httpUrlConnection.setDoInput(true);
+            httpUrlConnection.setConnectTimeout(5000);
+            httpUrlConnection.setReadTimeout(10000);
@@
-            int responseCode = httpUrlConnection.getResponseCode();
+            int responseCode = httpUrlConnection.getResponseCode();
             logger.info("Broker response code: {}", responseCode);
@@
-                String errorResponse = "";
-                try {
-                    errorResponse = new String(httpUrlConnection.getErrorStream().readAllBytes());
-                } catch (Exception e) {
-                    // Ignore error reading error stream
-                }
+                String errorResponse = "";
+                try (var es = httpUrlConnection.getErrorStream()) {
+                    if (es != null) {
+                        errorResponse = new String(es.readAllBytes());
+                    }
+                } catch (Exception ignore) {
+                    // ignore
+                }
                 logger.error("Failed to publish event. Response code: {}, Error: {}", responseCode, errorResponse);
                 throw new RuntimeException("Failed to publish event. Response code: " + responseCode);
             }
 
         } catch (Exception e) {
             logger.error("Error publishing event to broker", e);
             throw new RuntimeException("Failed to publish event", e);
+        } finally {
+            if (httpUrlConnection != null) {
+                httpUrlConnection.disconnect();
+            }
         }
     }

---

767-789: Move delivery block under spec (not subscriber)

Current placement is invalid and will be ignored.

 spec:
   broker: default
   filter:
     attributes:
       type: com.example.order.placed
   subscriber:
     ref:
       apiVersion: v1
       kind: Service
       name: order-processor
-    delivery:
-      deadLetterSink:
-        ref:
-          apiVersion: v1
-          kind: Service
-          name: dead-letter-service
-      retry: 3
+  delivery:
+    deadLetterSink:
+      ref:
+        apiVersion: v1
+        kind: Service
+        name: dead-letter-service
+    retry: 3

.gitignore (1)

1-17: Optional: Add a few common OS/editor ignores.

Consider also ignoring Windows and IDE artifacts to reduce churn:

• Thumbs.db
• .idea/ (JetBrains)
• .vscode/ (workspace settings, only if not intentionally shared)

Proposed patch:

+.idea/
+.vscode/
+Thumbs.db

docs/en/solutions/Leveraging_Knative_Eventing_for_Cloud_Event_Publishing_and_Consuming.md (7)

128-128: Grammar nit: “Let’s”

Use the contraction.

-Lets create a simple HTTP service that receives and output events as logs:
+Let's create a simple HTTP service that receives and outputs events as logs:

---

239-239: Consistent naming: “Spring Boot”

Align heading with standard spelling used elsewhere in the doc.

-## Chapter 3. Enabling SpringBoot Applications for Cloud Events
+## Chapter 3. Enabling Spring Boot Applications for Cloud Events

---

294-294: Remove unused import

java.util.Map isn’t used.

-import java.util.Map;

---

679-679: Unify broker ingress hostname across docs

Earlier examples use knative-operator; this env var uses knative-eventing. Pick one to avoid confusion. Below aligns to earlier “kubectl get broker” URL.

-          value: "http://broker-ingress.knative-eventing.svc.cluster.local/my-app-namespace/default"
+          value: "http://broker-ingress.knative-operator.svc.cluster.local/my-app-namespace/default"

If your cluster exposes broker-ingress via knative-eventing instead, switch the earlier examples to match. Please confirm which is correct for ACP v3.

---

695-695: Consistent naming: “Spring Boot”

Fix heading.

-### Testing the SpringBoot Application
+### Testing the Spring Boot Application

---

699-705: Make curl test workable from a developer machine

Add port-forward so the service is reachable; then curl localhost.

-   curl -X POST http://springboot-event-app/api/users \
+   kubectl -n my-app-namespace port-forward svc/springboot-event-app 8080:80
+   curl -X POST http://localhost:8080/api/users \
      -H "Content-Type: application/json" \
      -d '{"email": "user@example.com"}'

---

401-405: Property vs env var mapping sanity check

You use @value("knative.broker.url") with a default and also set KNATIVE_BROKER_URL via env. Spring Boot will map KNATIVE_BROKER_URL → knative.broker.url (OK). Ensure the value matches the earlier Broker URL and avoid drift between application.yml and the Deployment env var.

Also applies to: 567-574, 679-679

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

docs/en/solutions/Leveraging_Knative_Eventing_for_Cloud_Event_Publishing_and_Consuming.md (5)

28-28: Add descriptive alt text to image (accessibility)
Missing alt text violates MD045 and hurts accessibility.

Apply:

-![](/KB250700002/knative-eventing.png)
+![Knative Eventing architecture diagram showing producers, broker, triggers, and consumers](/KB250700002/knative-eventing.png)

---

281-321: Avoid NPE on event.getData() and drop unused import
Directly dereferencing event.getData() may NPE; JsonFormat import is unused.

Apply:

-import io.cloudevents.jackson.JsonFormat;
@@
-            logger.info("  Data: {}", new String(event.getData().toBytes()));
+            if (event.getData() != null) {
+                logger.info("  Data: {}", new String(event.getData().toBytes(), java.nio.charset.StandardCharsets.UTF_8));
+            } else {
+                logger.info("  Data: <none>");
+            }

---

463-499: Add HTTP timeouts and always disconnect to avoid resource leaks
No timeouts and missing disconnect can hang or leak connections.

Apply:

-    private void publishEvent(CloudEvent event) {
-        try {
-            URL url = URI.create(brokerUrl).toURL();
-            HttpURLConnection httpUrlConnection = (HttpURLConnection) url.openConnection();
+    private void publishEvent(CloudEvent event) {
+        HttpURLConnection httpUrlConnection = null;
+        try {
+            URL url = URI.create(brokerUrl).toURL();
+            httpUrlConnection = (HttpURLConnection) url.openConnection();
             httpUrlConnection.setRequestMethod("POST");
             httpUrlConnection.setDoOutput(true);
             httpUrlConnection.setDoInput(true);
+            httpUrlConnection.setConnectTimeout(5000);
+            httpUrlConnection.setReadTimeout(10000);
@@
-                String errorResponse = "";
-                try {
-                    errorResponse = new String(httpUrlConnection.getErrorStream().readAllBytes());
-                } catch (Exception e) {
-                    // Ignore error reading error stream
-                }
+                String errorResponse = "";
+                try (java.io.InputStream es = httpUrlConnection.getErrorStream()) {
+                    if (es != null) {
+                        errorResponse = new String(es.readAllBytes(), java.nio.charset.StandardCharsets.UTF_8);
+                    }
+                } catch (Exception e) {
+                    // Ignore error reading error stream
+                }
@@
-        } catch (Exception e) {
+        } catch (Exception e) {
             logger.error("Error publishing event to broker", e);
             throw new RuntimeException("Failed to publish event", e);
+        } finally {
+            if (httpUrlConnection != null) {
+                httpUrlConnection.disconnect();
+            }
         }
     }

Also applies to the same method’s error-stream handling pattern below.

---

741-759: Fix YAML: tabs, typo, and suffix filter syntax (and confirm feature gate)
Tabs make YAML invalid; amound is a typo; ensure suffix value is a quoted string and indentation is valid.

Apply:

 spec:
   broker: default
-  filters:
-  - all:
-	- exact:
-	      type: com.example.order.placed
-	- suffix:
-	    amount: "1000"  # Filter for amound suffixed attributes equals to 1000
+  filters:
+    - all:
+        - exact:
+            type: com.example.order.placed
+        - suffix:
+            amount: "1000"  # Filter for events whose string 'amount' extension ends with "1000"
   subscriber:
     ref:
       apiVersion: v1
       kind: Service
       name: high-value-order-processor

Ensure new-trigger-filters is enabled on your Knative version; otherwise switch to spec.filter.attributes or CEL.

---

767-789: Place delivery under spec, not subscriber
delivery under subscriber is invalid; move it to spec.delivery.

Apply:

 spec:
   broker: default
   filter:
     attributes:
       type: com.example.order.placed
   subscriber:
     ref:
       apiVersion: v1
       kind: Service
       name: order-processor
-    delivery:
-      deadLetterSink:
-        ref:
-          apiVersion: v1
-          kind: Service
-          name: dead-letter-service
-      retry: 3
+  delivery:
+    deadLetterSink:
+      ref:
+        apiVersion: v1
+        kind: Service
+        name: dead-letter-service
+    retry: 3

docs/en/solutions/Leveraging_Knative_Eventing_for_Cloud_Event_Publishing_and_Consuming.md (2)

401-403: Align broker ingress host consistently
Two different broker ingress hosts are used (knative-operator vs knative-eventing). Pick one that matches your install to avoid misroutes.

Example (adjust to your cluster):

-          value: "http://broker-ingress.knative-eventing.svc.cluster.local/my-app-namespace/default"
+          value: "http://broker-ingress.knative-operator.svc.cluster.local/my-app-namespace/default"

Note: Spring Boot will map KNATIVE_BROKER_URL -> knative.broker.url via relaxed binding.

Also applies to: 677-680

---

128-128: Minor wording/typo fixes in user-facing text
Improves clarity and consistency.

Apply:

-Lets create a simple HTTP service that receives and output events as logs:
+Let's create a simple HTTP service that receives events and outputs them to logs:

-          # Change to inhouse registry address and image
+          # Change to in-house registry address and image

-## Chapter 3. Enabling SpringBoot Applications for Cloud Events
+## Chapter 3. Enabling Spring Boot Applications for CloudEvents

-For this part we will still build uppon the EventConsumer created on the last part.
+For this part, we'll build upon the EventConsumer created in the previous section.

-### Testing the SpringBoot Application
+### Testing the Spring Boot application

Also applies to: 147-147, 238-239, 363-365, 695-695

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro